-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prodigy, SophiaG optimizers #1350
base: main
Are you sure you want to change the base?
Conversation
|
||
# update functions | ||
|
||
def update_fn(p, grad, exp_avg, lr, wd, beta1, beta2): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thie update_fn
function is redefined below on line 106.
src/axolotl/custom_optim/sophia.py
Outdated
hessian: List[Tensor], | ||
state_steps: List[Tensor], | ||
*, | ||
bs: int, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bs
you've set this as an int, but below you call bs.is_cuda()
https://wandb.ai/nruaif/Test_optim?workspace=user-nruaif |
I took a first pass at fixing the pylint errors, but mypy has still found a few issues
|
@Kimiko-AI I really think this pull request is worth finishing! Very useful - would love to see how Prodigy would perform on LLM training after I used it before on Stable Diffusion fine-tuning and it worked pretty well! |
Description
https://arxiv.org/pdf/2306.06101.pdf
https://arxiv.org/abs/2305.14342
Motivation and Context
How has this been tested?
No
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)